Skip to content
This repository has been archived by the owner on Jul 20, 2022. It is now read-only.

Add fromDialCode(String dialCode) #137

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Conversation

m-skolnick
Copy link
Contributor

@m-skolnick m-skolnick commented Feb 17, 2021

  1. Add fromDialCode(String dialCode)
  2. Deprecate fromCode(String isoCode) with replace with fromCountryCode(String countryCode) for clarity

@m-skolnick
Copy link
Contributor Author

Not sure what the best naming scheme is for replacing fromCode(String isoCode) maybe fromIsoCode(String isoCode) would have been better.

@imtoori imtoori merged commit 3568637 into imtoori:master Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants